Skip to content

Use monolog/monolog 3.x for PHP 8.1+ #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Use monolog/monolog 3.x for PHP 8.1+ #64

merged 3 commits into from
Jul 3, 2023

Conversation

n7studios
Copy link
Contributor

Summary

Permit using monolog/monolog 3.x to ensure this package works with other packages that require 3.x, such as Laravel 10, as reported here.

PHP < 8.1 will continue to use monolog 2.x, with our tests running in PHP 7.4 and 8.0 confirming this works.

Testing

  • testDebugEnabled: Test that the debug log is created and written to with expected data when debugging is enabled
  • testDebugDisabled: Test that the debug log is not created when debugging is disabled

Checklist

@n7studios n7studios self-assigned this Jul 3, 2023
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team July 3, 2023 11:58
@n7studios n7studios marked this pull request as ready for review July 3, 2023 11:58
@n7studios n7studios added this to the 1.2.0 milestone Jul 3, 2023
@n7studios n7studios merged commit 562a14f into master Jul 3, 2023
@jtolj
Copy link

jtolj commented Jul 5, 2023

@n7studios thanks for getting this updated so quickly!

@n7studios n7studios deleted the use-monolog-3.0 branch September 11, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants