Define log location; mask API credentials #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
debugLogFileLocation
parameter to the class constructor, allowing developers to specify where the log file should be written to, instead of the defaultsrc/logs/debug.log
, which may be public facing.Masks the API Key and Secret in the log file if detected in the
create_log()
message.Testing
testDebugEnabledWithCustomLogFile
: Test that debug logging works when enabled, a custom debug log file and path is specified and an API call is made.testDebugAPIKeyAndSecretAreMasked
: Test that debug logging works when enabled and an API call is made, with the API Key and Secret masked in the log file.Checklist