Skip to content

v4 API: Subscribers #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 26, 2024
Merged

v4 API: Subscribers #79

merged 13 commits into from
Mar 26, 2024

Conversation

n7studios
Copy link
Contributor

Summary

Adds support for endpoints in the subscribers section of the v4 API.

Testing

Tests pass.

Checklist

@n7studios n7studios added this to the 2.0 milestone Mar 22, 2024
@n7studios n7studios self-assigned this Mar 22, 2024
@n7studios n7studios requested review from a team, noelherrick and jenessawhite and removed request for a team March 25, 2024 14:50
@n7studios n7studios marked this pull request as ready for review March 25, 2024 14:50
Copy link

@noelherrick noelherrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As far as the lines that cleanup the subscribers (by unsubscribing them), is there a way to put that into a method or block that always runs, even if there's an assertion failure?

@n7studios
Copy link
Contributor Author

Looks good. As far as the lines that cleanup the subscribers (by unsubscribing them), is there a way to put that into a method or block that always runs, even if there's an assertion failure?

Yes - I'll open a PR for that today.

@n7studios n7studios merged commit 37046c4 into v4-api-oauth Mar 26, 2024
@n7studios n7studios deleted the v4-api-subscribers branch June 26, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants