-
Notifications
You must be signed in to change notification settings - Fork 54
Add pybind11 patches #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pybind11 patches #325
Conversation
A comment about patch branches in general. I prefer 2 commits. One which pushes the original files and a second which applies the patch. That will allow reviewers to see what's actually being changed. |
69277e6
to
e5cadf1
Compare
Like this? |
Yes, thank you :) |
Jenkins test this please |
The builds are failing:
Is Jenkins not configured for Python? Does this usually happen? |
FYI, this is more for Dawkins than anyone, but if there are useful changes being made, I would prefer they go into master, not some frankenbranch which will not merge. Are these changes useful for pybind11 in general? |
Kyle, do you want to push that into viame/master or plain master? Jenkins is configured for master, if viame/master needs anything different I wouldn't expect it to work. |
Jenkins is not configured with python and any packages which are added need to assume it can be turned on or off. |
@hughed2 this branch cannot go into master, it was taken from viame/master. |
This adds a set of patches to pybind11 that fix pybind/pybind11#1276 (the changes I've made can be seen in pybind/pybind11#1286)