Use uv instead of plain pip #2999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
commented
Sep 6, 2025
Comment on lines
+46
to
+54
| "coverage==7.8.2", | ||
| "importlib-metadata==8.7.0", | ||
| "mypy==1.16.1", | ||
| "ruff==0.12.1", | ||
| "types-PyYAML==6.0.12.20250516", | ||
| "pytest==8.4.1", | ||
| "trio==0.30.0", | ||
| # Check dist | ||
| "twine==6.1.0" |
Owner
Author
There was a problem hiding this comment.
Since we have a lockfile, we can just restrict the minimum here. I'll do this after.
|
Please poke me if you have any problems! |
Owner
Author
Sure! Thanks :) |
Kludex
commented
Sep 6, 2025
Comment on lines
+44
to
+45
| # We add starlette[full] so `uv sync` considers the extras. | ||
| "starlette[full]", |
Owner
Author
There was a problem hiding this comment.
@zanieb I had to do this - which is actually the first time I do it...
This is to avoid uv sync --all-extras (I can just do uv sync). Is there a way to add it to default-groups instead?
There was a problem hiding this comment.
I think you want astral-sh/uv#12965, which we aren't sure what to do with.
This is an appropriate workaround.
Owner
Author
There was a problem hiding this comment.
Funny. Copilot actually suggested me to use the default-extras 😅
All good then. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.