-
-
Notifications
You must be signed in to change notification settings - Fork 892
Bump h11 #2621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump h11 #2621
Conversation
|
A note that when a dependency has a vulnerability issue, we are not forced to update the constraints. Users can already bump their The vulnerability is on the dependency, not on uvicorn. That said, I'll merge this soon. |
|
Any update on when will this be merged and released? |
|
I think there's a TODO on h11_impl.py about changing something when this is released. I'll check later. |
|
Thanks for the update! |
|
Well... I'm not sure if you intended to create this PR... This PR doesn't make you require h11 >= 0.16 when installing uvicorn - it just bumps when developing in this repository. |
|
I'll merge this because it removes the git installation. |
|
To Kludex's point, should we update https://github.com/encode/uvicorn/blob/master/pyproject.toml#L34 to ensure that consumers of uvicorn are not pulling in a vulnerable version of h11? |
|
No. There's no need for it. |
Summary
h11 has now released version 0.16.0 which amongst other things fixes a vulnerability, I've updated the requirements in uvicorn to use this release instead of targeting the main branch so we can use the latest tagged release and avoid this vulnerability
Checklist