fix!: Expose ZclFrame on message event#1473
Merged
Merged
Conversation
CodSpeed Performance ReportMerging #1473 will not alter performanceComparing Summary
|
Collaborator
|
I don't really like the fact it opens up ZHC (and external converters) to manipulate what should be only ZH/spec-derived data. It's very bug-prone, especially in cases where the frame might be used after by some other process and it comes up with unexpected formats (not sure if/how, but reference issues are very hard to track down/debug). |
Koenkk
added a commit
that referenced
this pull request
Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the whole frame in just attributes separately, required for e.g. Koenkk/zigbee-herdsman-converters#9711 where the raw frame is needed.