fix(git): default file name from name on create & show file name for MCP in settings [INS-2630]#10022
Open
pavkout wants to merge 3 commits into
Open
fix(git): default file name from name on create & show file name for MCP in settings [INS-2630]#10022pavkout wants to merge 3 commits into
pavkout wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Git-backed workspace UX so users don’t have to type the same “Name” and “File name” twice when creating workspaces, and aligns MCP client settings with the other Git-backed workspace types by exposing the file name field in settings.
Changes:
- Derive the “File name” from “Name” in the new workspace modal until the user manually edits the file name.
- Show the “File name” field for MCP clients in the workspace settings modal (Git projects).
- Keep using the existing
safeToUseInsomniaFileName*sanitization path for Git file naming.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/insomnia/src/ui/components/modals/workspace-settings-modal.tsx | Removes the MCP-specific hiding of the Git “File name” field in workspace settings. |
| packages/insomnia/src/ui/components/modals/new-workspace-modal.tsx | Adds “name → fileName” defaulting behavior with a manual-edit opt-out flag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
140
to
144
| {project && | ||
| models.project.isGitProject(project) && | ||
| gitRepoTreeFetcher.data && | ||
| !models.workspace.isMcp(workspace) && ( | ||
| gitRepoTreeFetcher.data && ( | ||
| <TextField | ||
| name="fileName" |
fiosman
previously approved these changes
Jun 3, 2026
74f20e4 to
898a433
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When creating a workspace (collection, doc, mock server, environment, MCP client) in a Git-backed project, the form asks for both a Name and a File name. Previously the File name didn't follow the Name, so users had to type the same thing twice.
This PR:
safeToUseInsomniaFileNamesanitizer, e.g.My Collection→my_collection.yaml). Once you manually edit the File name, we stop overriding it so your custom value sticks.!isMcp), even though the create modal collects a file name for it and the update route already storesgitFilePathgenerically. This makes create/settings consistent and lets you rename the MCP file.The File name field stays fully editable and we don't lock it down or block on duplicates — we're only defaulting it. This applies to all five workspace types via the shared Name field; no per-type handling.
How to test
Notes