Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7853 +/- ##
=======================================
- Coverage 78.3% 77.7% -0.6%
=======================================
Files 222 222
Lines 20786 20969 +183
=======================================
+ Hits 16283 16309 +26
- Misses 3472 3621 +149
- Partials 1031 1039 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
programmer04
approved these changes
Mar 10, 2026
1 task
pmalek
added a commit
that referenced
this pull request
Mar 11, 2026
* fix: fix generating SNIs in dbless * tests: fix golden tests files * tests: fix golden tests files * chore: add changelog
1 task
pmalek
added a commit
that referenced
this pull request
Mar 11, 2026
* fix: fix generating SNIs in dbless * tests: fix golden tests files * tests: fix golden tests files * chore: add changelog
1 task
programmer04
pushed a commit
that referenced
this pull request
Mar 13, 2026
programmer04
pushed a commit
that referenced
this pull request
Mar 13, 2026
Copilot AI
added a commit
that referenced
this pull request
Mar 28, 2026
…ess mode The !inmemory guard introduced by PR #7853 (fixing KIC issue #7831) caused a regression reported in issue #7869: Kong OSS 3.9 rejects configs without cert back-references on SNIs when consumer credentials are also present. The 'value must be null' error in #7831 was specific to Kong Enterprise 3.9.0.1 and was fixed in Kong 3.9.1.0. The repro script confirms that 3.9.1.0 both accepts and requires cert back-references in complex configs. Fix: remove the inmemory gate so GetFCertificateFromKongCert always sets Certificate.ID on each nested SNI when the cert has an ID. Also remove the now-unused inmemory parameter from GetFCertificateFromKongCert, getCertsSNIs, and GenerateDeckContentParams.InMemory. Update affected unit tests and regenerate all golden files. Agent-Logs-Url: https://github.com/Kong/kubernetes-ingress-controller/sessions/03738126-ac54-4dcf-bb35-f77aa9b7dfc3 Co-authored-by: pmalek <739996+pmalek@users.noreply.github.com>
1 task
pmalek
added a commit
that referenced
this pull request
Mar 31, 2026
team-k8s-bot
pushed a commit
that referenced
this pull request
Mar 31, 2026
pmalek
added a commit
that referenced
this pull request
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR handles the differences in generating Kong SNIs based on whether KIC is running dbless or db backed.
Which issue this PR fixes:
Fixes #7831
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR