-
Notifications
You must be signed in to change notification settings - Fork 26
fix(*): replace deprecated pl.xml module with luaexpat #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bb47a2f
to
482b821
Compare
By running the original tests I found that Luaexpat's behaviour seems quite different from Penlight's implementation of simple XML parser...
It seems that luaexpat is parsing those new line characters into items which is not expected |
@Tieske lua-resty-aws/src/resty/aws/request/build.lua Line 236 in 98683b8
|
Yes, because PL was taking shortcuts, and dismissed whitespace, which is significant in the XML standard. Though in most use cases it is not. |
2e0c43d
to
61aee17
Compare
OpenResty 1.17.8.2's image seems too old to have a libexpat >= 2.3.0, so I changed it to build libexpat from source. |
753c9c5
to
7ffb98a
Compare
Summary
This PR has the following changes:
pl.xml
module with luaexpat. Currently, the XML parser is only used inTokenFileWebIdentityCredentials.lua
. Since STS service is responding with XML response, it is also needed inChainableTemporaryCredentials.lua
. This should solve Dependency on deprecated Penlight XML (pl.xml) module #37 (as long as luaexpat does not get deprecated :P)