Skip to content

Conversation

Chalks
Copy link
Contributor

@Chalks Chalks commented May 28, 2025

Summary

Satisfies MA-3976

We need aggregation units for data generation to support dashboard previews. Currently this is determined here. Instead we're moving that logic into analytics-utilities as that's a more clear place for it to live and allows a lot more things to use it.

After this merges, here's a followup PR to remove that code from kanalytics and import from here instead.

@Chalks Chalks requested a review from a team as a code owner May 28, 2025 22:11
@Chalks Chalks force-pushed the feat/unit-calculation-ma-3976 branch from 44ecc95 to 2deb3d5 Compare May 28, 2025 22:31
@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/analytics-utilities@pr-2148
@kong-ui-public/analytics-chart@pr-2148
@kong-ui-public/analytics-config-store@pr-2148
@kong-ui-public/analytics-geo-map@pr-2148
@kong-ui-public/portal-analytics-bridge@pr-2148
@kong-ui-public/analytics-metric-provider@pr-2148
@kong-ui-public/dashboard-renderer@pr-2148

Copy link
Contributor

@adorack adorack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to review.

@adorack
Copy link
Contributor

adorack commented May 29, 2025

(Pausing until we have a chance to discuss further.)

@Chalks Chalks marked this pull request as draft June 2, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants