-
Notifications
You must be signed in to change notification settings - Fork 473
Update Kotlin to 2.3.0 and fixes IT #4402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
||
| actual shouldBe """ | ||
| gradle: 7.6.4, 8.14.3, 9.1.0 | ||
| kgp: 1.9.25, 2.0.21, 2.1.21, 2.2.21, 2.3.0-Beta2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we had some merge conflict, or something, as TestedVersionsSource.kt uses RC, but in tests it was Beta2 - the TC IT were failing because of it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get there versions from TestedVersions.kt? Or write instructions for updating them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outputs here are based on a dynamic combination of versions from TestedVersionsSource.kt - which is the new test infra used only for testing DGPv2.
And this test was introduced in #4366 specifically to verify that, in various AGP-related scenarios, we test with all versions supported for a specific AGP execution mode.
Therefore, we should not obtain versions from there. However, I will add an instruction on how to update them: run the test, verify the output is correct, and replace it accordingly.
|
|
||
| actual shouldBe """ | ||
| gradle: 7.6.4, 8.14.3, 9.1.0 | ||
| kgp: 1.9.25, 2.0.21, 2.1.21, 2.2.21, 2.3.0-Beta2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get there versions from TestedVersions.kt? Or write instructions for updating them?
… compile with older AGP version
…0 which now creates this sourceSet
No description provided.