Conversation
|
First of all, thank you for the revision of my PR @KreativJos. I think it would be important to add default BuildActions for files like in VS:
Since I'm now working on a C# project again, I will test this PR for the next few weeks. |
rtynski
left a comment
There was a problem hiding this comment.
Try coding without else.
One level exit in function.
Use the same style.
|
Will try to take a look at this tomorrow or Wednesday |
|
@hampoelz Rewrote most of the writer & surrounding stuff. Now it is using interface types to ensure correct handling (learned a lot about typescript this way).
As for your points:
|
|
Thank you for your work @KreativJos! I'll test the changes soon.
That's interesting, I didn't know that. However, adding a setting is a good approach and ensures backwards compatibility.
Yeah you're totally right. - One solution I had in mind was to map the build action based on the file extension (as you already wrote in 4.) to automatically add the files Build Actions - if the setting is active (as in 1. discussed). This would also eliminate the need to remember BuildActions for file types. (Refs to 4.) When adding a xaml/cshtml/etc file, it should be checked if there is a cs file with the same name and with the build action "compile" in the folder so that these two files can be linked. |
Reworked parts of PR #17 from hampoelz: