Skip to content

feat: support customization of sharding labels #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

Eikykun
Copy link
Member

@Eikykun Eikykun commented Jan 3, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  1. Support label redefinition through flags:
  • ctrlmesh.kusionstack.io/control, the sharding hash label.
  • ctrlmesh.kusionstack.io/shard-hash, the controller-mesh control label.
  • ctrlmesh.kusionstack.io/namespace, the namespace label.
  1. Support disable patch runnable.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@Eikykun Eikykun self-assigned this Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (8101267) 36.27% compared to head (ba4702d) 35.66%.

Files Patch % Lines
...r/controllers/patchrunnable/labelpatch_runnable.go 0.00% 13 Missing ⚠️
pkg/manager/controllers/patchrunnable/resource.go 0.00% 7 Missing ⚠️
.../controllers/shardingconfigserver/auto_sharding.go 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   36.27%   35.66%   -0.62%     
==========================================
  Files          16       16              
  Lines        1902     1904       +2     
==========================================
- Hits          690      679      -11     
- Misses       1145     1158      +13     
  Partials       67       67              
Flag Coverage Δ
unittests 35.66% <12.00%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eikykun Eikykun added the enhancement New feature or request label Jan 3, 2024
@Eikykun Eikykun merged commit 3b5f3ce into main Jan 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2024
@Eikykun Eikykun deleted the 240103-replace branch January 9, 2024 04:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant