Skip to content

catches errors properly #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2021
Merged

catches errors properly #124

merged 1 commit into from
Mar 19, 2021

Conversation

msokoloff1
Copy link
Contributor

@msokoloff1 msokoloff1 commented Mar 19, 2021

Error messages coming from the api were slightly changed. This update properly parses the new format.

@msokoloff1 msokoloff1 requested a review from nmaswood March 19, 2021 12:57
Copy link

@nmaswood nmaswood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

although do you mind including a short write up in the description

@msokoloff1 msokoloff1 merged commit 0ee9e00 into develop Mar 19, 2021
@msokoloff1 msokoloff1 deleted the ms/update-error-check branch March 19, 2021 13:00
msokoloff1 added a commit that referenced this pull request Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants