Skip to content

[SDK-200] Handle invalid enum update properly #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnoszczak merged 1 commit into from
Oct 18, 2023
Merged

[SDK-200] Handle invalid enum update properly #1263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion labelbox/schema/data_row_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,6 @@ def _parse_ontology(raw_ontology) -> List[DataRowMetadataSchema]:
options = []
for option in schema["options"]:
option["uid"] = option["id"]

options.append(
DataRowMetadataSchema(**{
**option,
Expand Down Expand Up @@ -366,7 +365,12 @@ def update_enum_option(self, name: str, option: str,
raise ValueError(
f"Updating Enum option is only supported for Enum metadata schema"
)
valid_options: List[str] = [o.name for o in schema.options]

if option not in valid_options:
raise ValueError(
f"Enum option '{option}' is not a valid option for Enum '{name}', valid options are: {valid_options}"
)
upsert_schema = _UpsertCustomMetadataSchemaInput(id=schema.uid,
name=schema.name,
kind=schema.kind.value)
Expand Down