Skip to content

fixed bugs, ready for release #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 25, 2021
Merged

fixed bugs, ready for release #127

merged 4 commits into from
Mar 25, 2021

Conversation

msokoloff1
Copy link
Contributor

@msokoloff1 msokoloff1 commented Mar 25, 2021 •
edited
Loading

  • Some extra information from the mal validation process was being added to the upload. This caused mal for subclasses to fail.
  • Bumped the version and updated the changelog so we are ready to release a fix.
  • Updated the README to include that the SDK works for python3.6
  • Fixed an incorrect reference to a notebook in the examples README.

@msokoloff1 msokoloff1 requested a review from gszpak March 25, 2021 13:20
@msokoloff1 msokoloff1 requested a review from nmaswood March 25, 2021 18:22
nmaswood
nmaswood approved these changes Mar 25, 2021
View reviewed changes
nmaswood
nmaswood approved these changes Mar 25, 2021
View reviewed changes
Copy link

@nmaswood nmaswood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you like you could even put at module scope

DUMMY_ID  =...

@msokoloff1 msokoloff1 merged commit 206c5b0 into develop Mar 25, 2021
@msokoloff1 msokoloff1 deleted the ms/bug-fix branch March 25, 2021 20:26
msokoloff1 added a commit that referenced this pull request Sep 22, 2021
@msokoloff1
Merge pull request #127 from Labelbox/ms/bug-fix
7575916 
fixed bugs, ready for release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmaswood nmaswood nmaswood approved these changes

@gszpak gszpak Awaiting requested review from gszpak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msokoloff1 @nmaswood