Skip to content

Vb/fact checking plt 1709 #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 20, 2024
Merged

Vb/fact checking plt 1709 #1883

merged 3 commits into from
Nov 20, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Oct 29, 2024 •
edited
Loading

Description

Story: https://labelbox.atlassian.net/browse/PLT-1709

Includes:

  • New FactCheckingTool for ontology
  • Refactored StepByStep reasoning using common Variant classes

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky force-pushed the VB/fact-checking_PLT-1709 branch from 4557c02 to e1a8c08 Compare October 29, 2024 18:23
vbrodsky
vbrodsky commented Oct 29, 2024
View reviewed changes
libs/labelbox/src/labelbox/schema/tool_building/step_reasoning_tool.py Outdated

correct_step: StepReasoningVariant = field(
default_factory=_create_correct_step
correct_step: Variant = field(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactored step-by-step reasoning tool using common Variant classes

@vbrodsky vbrodsky force-pushed the VB/fact-checking_PLT-1709 branch from 73219cf to ce302ea Compare October 29, 2024 19:11
@vbrodsky vbrodsky force-pushed the VB/fact-checking_PLT-1709 branch from ce302ea to 0d5fec3 Compare October 29, 2024 19:19
@vbrodsky vbrodsky marked this pull request as ready for review October 29, 2024 19:19
@vbrodsky vbrodsky requested a review from a team as a code owner October 29, 2024 19:19
@vbrodsky vbrodsky force-pushed the VB/fact-checking_PLT-1709 branch from 0d5fec3 to 4fce5b0 Compare October 29, 2024 19:22
@vbrodsky vbrodsky force-pushed the VB/fact-checking_PLT-1709 branch from 4fce5b0 to 6d6b3e4 Compare October 29, 2024 19:41
@vbrodsky vbrodsky force-pushed the VB/fact-checking_PLT-1709 branch from 6d6b3e4 to 7dd0332 Compare October 29, 2024 19:44
@vbrodsky vbrodsky force-pushed the VB/fact-checking_PLT-1709 branch from 7dd0332 to ae2f4a8 Compare November 1, 2024 18:24
@vbrodsky vbrodsky force-pushed the VB/fact-checking_PLT-1709 branch from cdf6552 to 11e89eb Compare November 19, 2024 03:41
@vbrodsky vbrodsky force-pushed the VB/fact-checking_PLT-1709 branch from 7f0dc54 to 0f3169f Compare November 19, 2024 19:50
@vbrodsky vbrodsky force-pushed the VB/fact-checking_PLT-1709 branch from 0f3169f to 647220f Compare November 19, 2024 19:54
@vbrodsky vbrodsky force-pushed the VB/fact-checking_PLT-1709 branch from db82fe6 to dc34cf5 Compare November 20, 2024 01:17
vbrodsky
vbrodsky commented Nov 20, 2024
View reviewed changes
libs/labelbox/src/labelbox/__init__.py
@@ -55,8 +55,8 @@
ResponseOption,
Tool,
)
from labelbox.schema.ontology import PromptResponseClassification
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed dupes

@vbrodsky vbrodsky force-pushed the VB/fact-checking_PLT-1709 branch from 19bc556 to 963dd71 Compare November 20, 2024 19:01
@vbrodsky vbrodsky requested a review from a team as a code owner November 20, 2024 19:01
@vbrodsky vbrodsky force-pushed the VB/fact-checking_PLT-1709 branch from 963dd71 to c3af277 Compare November 20, 2024 19:04
Gabefire
Gabefire approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@Gabefire Gabefire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! Are we going to support MAL imports for this new tool on offline MMC or is this just going to be for online?

@vbrodsky vbrodsky force-pushed the VB/fact-checking_PLT-1709 branch from c3af277 to d4dd844 Compare November 20, 2024 21:38
@vbrodsky vbrodsky merged commit 48dca96 into develop Nov 20, 2024
13 of 23 checks passed
@vbrodsky vbrodsky deleted the VB/fact-checking_PLT-1709 branch November 20, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabefire Gabefire Gabefire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbrodsky @Gabefire