[PLT-1677] Added get mal import functions to replace old BulkImportRequest class #1909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabefire
commented
Nov 16, 2024
| MALPredictionImport, | ||
| ) | ||
|
|
||
| def get_label_imports(self) -> PaginatedCollection: |
There was a problem hiding this comment.
Note: Not going to add a delete path for regular label imports. This is because the mutation is internal and it can also put the data row in a bad state i.e. label with no annotations. We also already have SDk methods to delete and requeue labels so not needed.
Gabefire
commented
Nov 16, 2024
| @@ -587,6 +587,20 @@ def parent_id(self) -> str: | |||
| """ | |||
| return self.project().uid | |||
|
|
|||
| def delete(self) -> None: | |||
There was a problem hiding this comment.
I can't use the deletable inheritance to make this work for this class due to this being a hard delete, not flipping a field to False.
Gabefire
changed the title
|
Im okay approving because of codeowner requirement, but might be useful getting 👀 from someone from Model team |
tomislav-peharda
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
All Submissions