-
Notifications
You must be signed in to change notification settings - Fork 67
[PTDT-2863]: Feature schema attributes #1930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9131d21
[PTDT-2863]: Feature schema attributes
Tim-Kerr a58ce6c
Remove todos
Tim-Kerr 81fb2f4
cleanup
Tim-Kerr 0e06806
cleanup
Tim-Kerr eb16f04
Fixed unit tests
Tim-Kerr 6c3fc0e
Revert changes to lock files
Tim-Kerr 488a02b
removed python testing script file
Tim-Kerr e22265f
Formatted files
Tim-Kerr a8e8911
Added attributes to unit tests
Tim-Kerr d95092f
Formatting
Tim-Kerr 10e9ce2
Wrote integration tests for feature schema attributes
Tim-Kerr ac91b9a
Lint fix
Tim-Kerr acf4f18
Merge branch 'develop' into PTDT-2863
Tim-Kerr 6082463
Added warning to the Tool class when the user uses the attributes pro…
Tim-Kerr d4d9896
Refactored FeatureSchemaAttribute to be a dataclass
Tim-Kerr 44e05c4
Added from_dict method to the FeatureSchemaAttribute data class
Tim-Kerr 8769293
Fixed linting errors
Tim-Kerr 6824e0f
Fix lint error
Tim-Kerr 5ed769c
Updated the warning message to the standard message for feature schem…
Tim-Kerr f0dfa74
Merge branch 'develop' into PTDT-2863
Tim-Kerr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,33 @@ | ||
from typing import Annotated | ||
|
||
from typing import Annotated, List | ||
from pydantic import Field | ||
|
||
|
||
from dataclasses import dataclass | ||
|
||
from typing import Any, Dict, List | ||
|
||
|
||
@dataclass | ||
class FeatureSchemaAttribute: | ||
attributeName: str | ||
attributeValue: str | ||
|
||
def asdict(self): | ||
return { | ||
"attributeName": self.attributeName, | ||
"attributeValue": self.attributeValue, | ||
} | ||
|
||
@classmethod | ||
def from_dict(cls, dictionary: Dict[str, Any]) -> "FeatureSchemaAttribute": | ||
return cls( | ||
attributeName=dictionary["attributeName"], | ||
attributeValue=dictionary["attributeValue"], | ||
) | ||
|
||
|
||
FeatureSchemaId = Annotated[str, Field(min_length=25, max_length=25)] | ||
SchemaId = Annotated[str, Field(min_length=25, max_length=25)] | ||
FeatureSchemaAttributes = Annotated[ | ||
List[FeatureSchemaAttribute], Field(default_factory=list) | ||
vbrodsky marked this conversation as resolved.
Show resolved
Hide resolved
|
||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.