Skip to content

[PLT-2151] Vb/graphql upload plt 2151 #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Jan 3, 2025

Description

Story: https://labelbox.atlassian.net/browse/PLT-2151

This PR refactors code from GraphQL file upload that originally was duplicated in two different classes

I have discovered that Client execute() already supports GraphQL file upload and was able to remove duplicate code from other classes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky marked this pull request as ready for review January 3, 2025 21:27
@vbrodsky vbrodsky requested a review from a team as a code owner January 3, 2025 21:27
@vbrodsky vbrodsky merged commit df66bcd into develop Jan 6, 2025
18 of 23 checks passed
@vbrodsky vbrodsky deleted the VB/graphql-upload_PLT-2151 branch January 6, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants