-
Notifications
You must be signed in to change notification settings - Fork 67
Get invitations #1962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get invitations #1962
Conversation
4e7200e
to
3e47710
Compare
) | ||
|
||
# Add a small delay to ensure invite is created | ||
time.sleep(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might make it finicky is their any way we could make this behave more sync? Worse case a retry loop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple one something like time.sleep 5 seconds check if not there retry again up to 3 times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only mention because ive fix test with this sort of logic. Its annoying when they become finicky
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. I've removed the pause completely.
6437772
to
19b05a6
Compare
7e37cc8
to
7af08b9
Compare
Description
This PR addresses a request from Schneider Electric to be able to retrieve the list of pending invitations.
Notes:
This PR fixes a bug when a project is deleted after an invite was sent. To prevent an exception, deleted projects are not listed in
invite.project_roles
Functions
Example:
Fixes # (issue)
Type of change
Please delete options that are not relevant.
All Submissions
New Feature Submissions
Changes to Core Features