[pectra] Eigenpod CLI updates #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrower95
commented
Feb 19, 2025
| if withdrawalCredentials[0] != 1 { | ||
| // after the pectra upgrade, eigenpods may be found at: | ||
| // - `0x1` or `0x2` prefixed withdrawal addresses | ||
| if withdrawalCredentials[0] != 1 && withdrawalCredentials[0] != 2 { |
Contributor
Author
There was a problem hiding this comment.
support for 0x2 credentials
jbrower95
commented
Feb 19, 2025
| return false // we only care about slashed validators. | ||
| } | ||
| if v.Validator.WithdrawalCredentials[0] != 1 { | ||
| if v.Validator.WithdrawalCredentials[0] != 1 && v.Validator.WithdrawalCredentials[0] != 2 { |
Contributor
Author
There was a problem hiding this comment.
support for 0x2 credentials
Contributor
There was a problem hiding this comment.
a function for this would be nice for future changes but nbd
jbrower95
commented
Feb 19, 2025
| for i = 0; i < maxValidators; i++ { | ||
| validator := allValidators[i] | ||
| if validator == nil || validator.WithdrawalCredentials[0] != 1 { // withdrawalCredentials _need_ their first byte set to 1 to withdraw to execution layer. | ||
| if validator == nil || (validator.WithdrawalCredentials[0] != 1 && validator.WithdrawalCredentials[0] != 2) { // withdrawalCredentials _need_ their first byte set to 1 or 2 to withdraw to an eigenpod on the execution layer. |
Contributor
Author
There was a problem hiding this comment.
ditto 0x2 credentials
Collaborator
|
Just validated that all the places we check for 0x01, we also check 0x02 |
Collaborator
CI passes here, old version was pinned on a commit ( |
ypatil12
approved these changes
Feb 19, 2025
nii236
pushed a commit
to SwellNetwork/eigenpod-proofs-generation
that referenced
this pull request
Apr 21, 2025
* [pectra] fix the EigenPod CLI * major refactor * save * update mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
Major:
WithdrawalCredentialscan now be prefixed with0x1or0x2for eigenpods.github.com/attestantio/go-eth2-clientto latestRoutine/Cleanup:
loutility libraryAfter merging this, we will;