[Draft] Start selector observer #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for style-observer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/selector-observer.js
Outdated
Comment on lines
73
to
75
| this.#roots.delete(root); | ||
|
|
||
| let sheet = this.#roots.get(root); |
There was a problem hiding this comment.
I thought we had already removed the root from roots (in the line above) and can't get the style sheet associated with it, no? Shouldn't we move this.#roots.delete(root) at the end of unobserveRoot?
src/util/adopt-css.js
Outdated
| root = root.ownerDocument ?? root; | ||
| let window = root.defaultView; | ||
| let root = options.root.getRootNode?.() ?? options.root ?? globalThis.document; | ||
| let window = options.root.defaultView; |
There was a problem hiding this comment.
Shouldn't we operate root here, not options.root?
Co-authored-by: Dmitry Sharabin <[email protected]>
Co-authored-by: Dmitry Sharabin <[email protected]>
Co-authored-by: Dmitry Sharabin <[email protected]>
Co-authored-by: Dmitry Sharabin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still very early.
Looks like both an animation and a transition based approach might be workable. We might want to use both to minimize clashes with transitions & animations being overridden on the element (then it would only fail on those that have both). Or maybe over time one of them will prove clearly better.