-
Notifications
You must be signed in to change notification settings - Fork 9
[tests] Add older browser compatibility tests #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for style-observer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rewriting hTest with PostCSS seems ...overkill. The rest seems fine.
OK, I switched to an external stylesheet that fixes broken styles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ...still don't think we want to be stubbing in stylesheets for hTest. If people want to test in browsers that hTest doesn't support, I think it's totally valid that they're on their own.
You have to draw the line somewhere. Do you know how crappy this page looks in IE6? 😅 |
I am down to move the responsibility to the developers using these tests in older browsers. 😅 Let me delete redundant code real quick. |
7a23e6e
to
e6eed7e
Compare
e6eed7e
to
0a68121
Compare
Supported browsers
macOS
Windows