Skip to content

Conversation

DmitrySharabin
Copy link
Collaborator

Supported browsers

macOS

  • Chrome 89+
  • Firefox 90+
  • Safari 15.4+

Windows

  • Chrome 89+
  • Firefox 90+

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for style-observer ready!

Name Link
🔨 Latest commit 0a68121
🔍 Latest deploy log https://app.netlify.com/sites/style-observer/deploys/67add5fea0bf670008530be9
😎 Deploy Preview https://deploy-preview-55--style-observer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewriting hTest with PostCSS seems ...overkill. The rest seems fine.

@DmitrySharabin
Copy link
Collaborator Author

Rewriting hTest with PostCSS seems ...overkill. The rest seems fine.

OK, I switched to an external stylesheet that fixes broken styles.

Copy link
Owner

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ...still don't think we want to be stubbing in stylesheets for hTest. If people want to test in browsers that hTest doesn't support, I think it's totally valid that they're on their own.

@DmitrySharabin
Copy link
Collaborator Author

I ...still don't think we want to be stubbing in stylesheets for hTest. If people want to test in browsers that hTest doesn't support, I think it's totally valid that they're on their own.

That's much easier. Oof 😅

One thing that bothers me a bit. Take a look at how this page looks in older browsers:
image

Do we probably need some styles, though? We don't even know whether the tests pass. 🤷‍♂️ What do you think?

@LeaVerou
Copy link
Owner

You have to draw the line somewhere. Do you know how crappy this page looks in IE6? 😅

@DmitrySharabin
Copy link
Collaborator Author

I am down to move the responsibility to the developers using these tests in older browsers. 😅

Let me delete redundant code real quick.

@DmitrySharabin DmitrySharabin force-pushed the tests-old-browsers branch 4 times, most recently from 7a23e6e to e6eed7e Compare February 10, 2025 17:27
@DmitrySharabin DmitrySharabin changed the title [tests] Add old browser compatibility tests [tests] Add older browser compatibility tests Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants