Fix incorrect ActionData::axis_pair value when handling multiple DualAxisData#457
Merged
Merged
Conversation
which_pressed() for ActionData::axis_pairActionData::axis_pair value when handling multiple DualAxisData
ActionData::axis_pair value when handling multiple DualAxisDataActionData::axis_pair value when handling multiple DualAxisData
|
this fixes the issue i commented about on discord, glad someone figured out what was actually wrong |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The previous PR (#450) removed the accumulation for
ActionData::axis_pairinInputMap::which_pressed(), resulting in a problem where multipleDualAxisDataupdates would only preserve the last one due to the loss of previously recordedDualAxisData.A Simple Reproduction Case
While it functions correctly when pressing WASD, if only the arrow keys were pressed,
ActionState::axis_pair()will returnNone.Solution
Re-implement the accumulation of
ActionData::axis_pairinInputMap::which_pressed().Changelog
ActionData::axis_pairButtonState::JustPressedcheck by moving it into theinput_pressedchecking block and remove thepressedflag