Skip to content

Conversation

@lucuilearningpool
Copy link
Contributor

Closes LLC-1560.

When statements are added, they can bypass certain queues to avoid wasting resources (e.g., if the statements are historical).

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #849 (684d23b) into master (052bbce) will decrease coverage by 5.08%.
The diff coverage is 81.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #849      +/-   ##
==========================================
- Coverage   99.15%   94.06%   -5.09%     
==========================================
  Files         604      651      +47     
  Lines        6282     7032     +750     
  Branches      658      758     +100     
==========================================
+ Hits         6229     6615     +386     
- Misses         15      338     +323     
- Partials       38       79      +41     
Impacted Files Coverage Δ
...xpressPresenter/postStatements/alternateRequest.ts 33.82% <14.28%> (ø)
...ssPresenter/postStatements/storeWithAttachments.ts 44.44% <16.66%> (ø)
...c/apps/statements/expressPresenter/putStatement.ts 82.85% <71.42%> (ø)
...tatements/expressPresenter/postStatements/index.ts 82.60% <83.33%> (ø)
...expressPresenter/postStatements/storeStatements.ts 93.75% <100.00%> (ø)
...s/statements/expressPresenter/tests/utils/setup.ts 100.00% <100.00%> (ø)
...atements/expressPresenter/tests/utils/supertest.ts 100.00% <100.00%> (ø)
...tatements/expressPresenter/utils/storeStatement.ts 81.81% <100.00%> (ø)
...ssPresenter/utils/validateStatementBypassQueues.ts 100.00% <100.00%> (ø)
...c/apps/statements/service/storeStatements/index.ts 100.00% <100.00%> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 052bbce...684d23b. Read the comment docs.

Copy link
Member

@ryasmi ryasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, I'll let Vadim give the final approval as the lead 👍 Potentially missing tests judging by the code coverage report.

Copy link
Contributor

@crazy-grizzly crazy-grizzly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucuilearningpool , could you please take a look at my comments?

Copy link
Contributor

@crazy-grizzly crazy-grizzly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

It would be nice to fully cover the code but this requires adding tests for alternateRequest stuff which is really hard and there are no examples for this. For it's fine to pass this PR

Copy link
Contributor

@crazy-grizzly crazy-grizzly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lucuilearningpool lucuilearningpool merged commit 60451f5 into master Feb 2, 2022
@lucuilearningpool lucuilearningpool deleted the LLC-1560 branch February 2, 2022 12:41
@HT2Bot
Copy link
Member

HT2Bot commented Feb 2, 2022

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HT2Bot HT2Bot added the released label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants