-
Notifications
You must be signed in to change notification settings - Fork 62
feat(Statements): Add flexibility for bypassing queue (LLC-1560) #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #849 +/- ##
==========================================
- Coverage 99.15% 94.06% -5.09%
==========================================
Files 604 651 +47
Lines 6282 7032 +750
Branches 658 758 +100
==========================================
+ Hits 6229 6615 +386
- Misses 15 338 +323
- Partials 38 79 +41
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me, I'll let Vadim give the final approval as the lead 👍 Potentially missing tests judging by the code coverage report.
src/apps/statements/expressPresenter/utils/validateStatementBypassQueues.ts
Outdated
Show resolved
Hide resolved
crazy-grizzly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucuilearningpool , could you please take a look at my comments?
src/apps/statements/expressPresenter/postStatements/storeWithAttachments.ts
Outdated
Show resolved
Hide resolved
src/apps/statements/expressPresenter/utils/validateStatementBypassQueues.ts
Outdated
Show resolved
Hide resolved
…pleted queues" test
…alternate request (LLC-1560)
crazy-grizzly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
It would be nice to fully cover the code but this requires adding tests for alternateRequest stuff which is really hard and there are no examples for this. For it's fine to pass this PR
crazy-grizzly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes LLC-1560.
When statements are added, they can bypass certain queues to avoid wasting resources (e.g., if the statements are historical).