abstract-leveldown tests aren't all passing anymore #40
Comments
|
I max, I think you bumped abstract-leveldown too far, and the module is now broken. From 0.12 to 2.4 there are plenty of breaking changes: e693249. I hope to have a look asap. |
|
0.12 behavior differs from 2.4 |
relates to Level#40 fixes the problem with keys. doesn't fix the problem with snapshots
Fixes Level#43 Level#40 and Level#3. Unfortunately not easy to split out in separate commits. 1. Level#43 "snapshots seem not to work" The reason snapshots didn't work in the test, is because the iterator was only opened on the first call to _next. The new version opens the iterator right away in the constructor (if there is no KeyRange error). 2. Level#40 "abstract-leveldown tests aren't all passing anymore" Partially fixed by merging PR Level#42 and further fixed by this commit. 3. Level#3 "stop batch reads after limit is reached" The solution is stop calling cursor.continue() once the limit is reached. The transaction will automatically timeout as prescribed by the spec. idb-wrapper can't be used for this because limit is only respected if autoContinue is true. All 563 tests pass on: * Safari 9.0.3 * Firefox 45.0b2 * Firefox 46.0a2 * Iridium 44.1 (Chrome/44.0.2403.157)
Fixes Level#43 Level#40 and Level#3. Unfortunately not easy to split out in separate commits. 1. Level#43 "snapshots seem not to work" The reason snapshots didn't work in the test, is because the iterator was only opened on the first call to _next. The new version opens the iterator right away in the constructor (if there is no KeyRange error). 2. Level#40 "abstract-leveldown tests aren't all passing anymore" Partially fixed by merging PR Level#42 and further fixed by this commit. 3. Level#3 "stop batch reads after limit is reached" The solution is stop calling cursor.continue() once the limit is reached. The transaction will automatically timeout as prescribed by the spec. idb-wrapper can't be used for this because limit is only respected if autoContinue is true. All 563 tests pass on: * Safari 9.0.3 * Firefox 45.0b2 * Firefox 46.0a2 * Iridium 44.1 (Chrome/44.0.2403.157)
|
@maxogden @mcollina I'm actively working on this right now and I'd love to see this repository moved to the |
@gritzko We want to take stuff like that out of |
right now the tests don't pass in latest chrome. Not sure if it was something in chrome, idb-wrapper, or abstract-leveldown that changed but if someone has some time to dig in and try and make the tests pass it would be much appreciated
The text was updated successfully, but these errors were encountered: