Repository navigation
🧵 feat: Stream a Background Subagent Child Through Its Own Generation Job #18169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+3,019
−103
Merged
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1e7f411
🫀 feat: Let a Job Owner Keep a Silent Run Alive
danny-avila a43ec02
🧶 refactor: Share One Fold From Child Frames to Content Parts
danny-avila c9b618f
🏷️ feat: Mark the Generation Job of a Background Subagent Task
danny-avila 1a754b6
🧵 feat: Run a Background Child as a Resumable Generation Job
danny-avila 7cc8b3f
🪢 feat: Stream a Background Child Through Its Own Generation Job
danny-avila a9a9b3d
🔌 feat: Give the Server's Task Store Its Child Stream
danny-avila 80db8e6
🚧 fix: Refuse Chat Abort and Steer on a Background Child's Job
danny-avila 2a8dae4
🧹 fix: Evict a Finished Job Before a Live One at Capacity
danny-avila e232a12
🛰️ test: Read a Background Child's Stream From Another Replica
danny-avila baa75b5
🧽 chore: Sort Imports in the Child Stream Files
danny-avila 4e031c5
🧪 test: Expect the Child Stream Lever in the Activity Defaults
danny-avila 5420227
📜 feat: Store What a Background Child Streamed as Standard Content (#…
danny-avila f265873
🛟 fix: Keep a Stalled or Failing Child Stream From Touching Its Child
danny-avila 65173f3
🧯 fix: Let a Child Stream Observe Its Run Without Ever Stopping It
danny-avila 5b52e4a
♻️ fix: Replace a Dead Background Child's Job on Its Thread
danny-avila c7a21e4
🧱 fix: Fail the Abort Guard Closed and Budget Content Against the Who…
danny-avila cd6b424
🪶 refactor: Settle a Child Stream Once and Fold a Frame It Cannot Copy
danny-avila 1611161
🧪 test: Cover the Child Stream's Failure Branches and the Content Fold
danny-avila File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this lookup encounters a transient store error but the subsequent lookup succeeds, calling
next()bypasses the background-child refusal entirely. The downstream/chat/aborthandler inapi/server/routes/agents/index.jsindependently reads the job and no longer checksbackgroundChildJobRefusal, so it can abort the child's stream and execute its chat-shaped partial-message persistence while the child continues running. Forward the lookup error to the request error boundary, or ensure any retried lookup passes through the refusal check before abort processing.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in c7a21e4. A failed lookup now calls
next(error), so the request ends at the error boundary and the route's chat-shaped abort never runs on a job the guard could not read.guard.spec.ts: "fails closed, without reaching the route, when the job lookup fails" asserts a 500 and that the route handler is not reached.