Repository navigation
💺 feat: Hide Tool-Limit Recovery Actions in Read-Only Chats - #18196
Conversation
7abd78d to
6fde7b7
Compare
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
6fde7b7 to
e08f56e
Compare
e08f56e to
7eff19f
Compare
|
@codex review Head 7eff19f037. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
678c337 to
bbde649
Compare
bbde649 to
c42f28d
Compare
c42f28d to
ce902a5
Compare
ce902a5 to
8fdefbd
Compare
c7e6d50 to
accb97d
Compare
accb97d to
27e9cef
Compare
27e9cef to
58aa201
Compare
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
ChatContract.readOnly(#18193) lets a chat say the reader takes no turn in it, and a read-only chat's rows already offer no regenerate, edit or continue. One row action is decided elsewhere: the tool-call-limit notice offers Keep going and Answer now from its own gate, which checks only that the chat is live on the tail message. In a conversation that is followed rather than driven, such as a subagent's child thread, both buttons would be drawn and wired to handlers that do nothing.With this, a read-only chat's notice explains what happened without offering either recovery action.
Eighth in a stack, on #18195.
How it works
// components/parts/ToolCallLimitNotice.tsx const canAct = chat?.ask != null && + chat.readOnly !== true && chat.isSubmitting !== true && chat.latestMessageId === message.messageId;The notice reads
chat.readOnlyfromChatContext, where it already reads whether the chat is live on the tail message.The contract field, the row rules and the view provider's read-only mode were part of this PR and moved down into #18193, so the followed view is read-only from the PR that introduces it.
Type of change
Testing
Tested environments/configuration:
jsdom, with the package's real notice.
Automated tests:
ToolCallLimitNotice.spec.tsx: a read-only chat offers neither recovery action. The rule was removed to confirm the test fails.packages/chat:npx jest(3905 tests, run at the top of the stack);npx tsc --noEmit;npm run static-checks -- --against origin/dev.Screenshots / recordings
No user-facing change:
readOnlyis absent for every chat the app renders today.Risk / compatibility
readOnlydefaults to absent, which is today's behavior for main chat, the added pane and the shared view.