Repository navigation
🪪 fix: Draw a Subagent's Brief as the Dispatching Agent's Turn #18278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -190,6 +190,11 @@ export default function SubagentThreadPanel({ | |
| selection.partIndex, | ||
| selection.durable?.threadId, | ||
| ); | ||
| /** The brief is the dispatching agent's turn, drawn with its name and face. */ | ||
| const briefAuthor = useMemo( | ||
| () => ({ icon: parentAuthor.icon, label: parentAuthor.name }), | ||
| [parentAuthor.icon, parentAuthor.name], | ||
| ); | ||
| const threadId = selection.durable?.threadId ?? ''; | ||
| const taskId = selection.durable?.taskId ?? ''; | ||
| const receiptScope = useMemo( | ||
|
|
@@ -1752,6 +1757,7 @@ export default function SubagentThreadPanel({ | |
| threadId={threadId} | ||
| followed={followed} | ||
| agentId={taskView?.agentId ?? foregroundAgentId} | ||
| briefAuthor={briefAuthor} | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Valid. Fixed in dee57ad: the brief's author is now the same value the durable view passes as its turn's parent author, |
||
| controls={activity.controls} | ||
| controlsTruncated={activity.controlsTruncated} | ||
| onCancelControl={ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid. Fixed in dee57ad: a turn drawn for an explicit author gets no model hover label. The label on offer was the model of the conversation's agent, which for a child thread is the child, so the brief's heading named the parent and revealed the child's model on hover and to screen readers. Pinned in
subagents/__tests__/followed.spec.tsx(the brief's heading does not contain the child's model), which fails against the previous code.