Repository navigation
🧪 test: Cover a Pause Answered Inside a Side Chat - #18429
Conversation
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
41e889f to
b7ae76a
Compare
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
A side chat (#18417) is a conversation driven through a core
Chatbeside the main one. Nothing covered what happens when its agent pauses for the reader: a tool waiting for approval, or anask_user_question. I had listed that as unsupported in #18417, from reading the code. A browser run showed both work, so this adds the two scenarios that keep it that way. No product code changes.What the scenarios pin down, for each kind of pause:
/api/agents/chat/resumefor the side conversation, not the one beside it;Type of change
Testing
Tested environments/configuration:
Chromium on the mock e2e lane (in-memory Mongo, fake model), against this branch's own server. The pauses are the production ones: the fake model stops a real agent run at the tool, and the card, the resume request and the stream are the app's.
Automated tests:
e2e/specs/mock/scenarios/side-chat-pauses.spec.ts:@scenario:side-chat-answers-ask-user-questionand@scenario:side-chat-approves-tool-call. Both passed twice locally (--repeat-each=2, 4/4).Risk / compatibility
Tests only, for the side chat that #18417 added.
Not covered here: a pause that is already waiting when a side chat is opened later (the side chat would attach to it rather than drive it). No entry point reaches that state yet, since a side chat only opens from a continuation.