Skip to content

🧪 test: Cover a Pause Answered Inside a Side Chat - #18429

Merged
danny-avila merged 1 commit into
devfrom
danny-avila/side-chat-pauses-e2e
Nov 18, 2026
Merged

danny-avila merged 1 commit into
devfrom
danny-avila/side-chat-pauses-e2e

Conversation

@danny-avila

@danny-avila danny-avila commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

A side chat (#18417) is a conversation driven through a core Chat beside the main one. Nothing covered what happens when its agent pauses for the reader: a tool waiting for approval, or an ask_user_question. I had listed that as unsupported in #18417, from reading the code. A browser run showed both work, so this adds the two scenarios that keep it that way. No product code changes.

What the scenarios pin down, for each kind of pause:

  • the request is drawn in the side chat, on the turn that asked;
  • the answer is posted to /api/agents/chat/resume for the side conversation, not the one beside it;
  • the generation carries on in the side chat, on the stream it was already reading, and the composer returns to Send;
  • the page stays on the conversation the side chat was opened from, and an ask-user question offers no hand-off to the main chat's message box.

Type of change

  • Tests / tooling / CI

Testing

Tested environments/configuration:

Chromium on the mock e2e lane (in-memory Mongo, fake model), against this branch's own server. The pauses are the production ones: the fake model stops a real agent run at the tool, and the card, the resume request and the stream are the app's.

Automated tests:

  • e2e/specs/mock/scenarios/side-chat-pauses.spec.ts: @scenario:side-chat-answers-ask-user-question and @scenario:side-chat-approves-tool-call. Both passed twice locally (--repeat-each=2, 4/4).

Risk / compatibility

Tests only, for the side chat that #18417 added.

Not covered here: a pause that is already waiting when a side chat is opened later (the side chat would attach to it rather than drive it). No entry point reaches that state yet, since a side chat only opens from a continuation.

@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Head 41e889f.

Base automatically changed from danny-avila/side-chat-surface to dev November 18, 2026 16:58
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 41e889f3f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T17:00:27.534989Z b7ae76a Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Head b7ae76a. The same test file, rebased onto dev now that #18417 is merged.

@danny-avila
danny-avila force-pushed the danny-avila/side-chat-pauses-e2e branch from 41e889f to b7ae76a Compare November 18, 2026 16:59
@danny-avila
danny-avila marked this pull request as ready for review November 18, 2026 16:59
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: b7ae76a276

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila
danny-avila merged commit 004b763 into dev Nov 18, 2026
37 of 38 checks passed
@danny-avila
danny-avila deleted the danny-avila/side-chat-pauses-e2e branch November 18, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant