Skip to content

🧪 test: Cover a Side Chat's Draft Across a Running Reply - #18485

Draft
danny-avila wants to merge 2 commits into
danny-avila/side-chat-composerfrom
danny-avila/side-chat-running-drafts
Draft

danny-avila wants to merge 2 commits into
danny-avila/side-chat-composerfrom
danny-avila/side-chat-running-drafts

Conversation

@danny-avila

Copy link
Copy Markdown
Collaborator

Summary

Two cases #18469 listed as known and not fixed are fixed by #18472, and this adds the scenarios that hold them:

  • Words written in a side chat while its reply is still running go with the conversation when it is opened as the main chat. Main chat attaches to the running reply and keeps them in its composer, through the run and after it.
  • A side chat closed while its reply runs and opened again before it ends still has the words written in it.

Both failed for the same reason, which is main chat's and not the side chat's: when a composer's storage switched to the pending key for a run it did not send, the pending record was restored over whatever the field held. #18472 keeps the field's words in that case, and keeps the words a composer is first drawn with when there is no record to restore.

No source changes of its own. Stacked on #18469 and depends on #18472, whose commit is included here until it merges into dev; the only file this pull request adds to is e2e/specs/mock/scenarios/side-chat-composer.spec.ts.

Type of change

  • Tests / tooling / CI

Testing

Both scenarios were run against a build of this branch with #18472's change to useAutoSave.ts reverted and fail there (Expected: "thought of while it ran", Received: "" and Expected: "picked up where I left it", Received: ""), and pass with it.

Tested environments/configuration:

  • Chromium via Playwright, mock e2e lane (in-memory MongoDB, fake model), desktop 1440×900. Save Drafts on.

Automated tests:

  • New scenarios @scenario:side-chat-composer-running-draft-follows-the-conversation and @scenario:side-chat-composer-running-draft-survives-reopening. The composer spec (12 scenarios) and composer-draft-survives-run.spec.ts pass together.

@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Head: eb8021a

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T03:17:07.346883Z eb8021a Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: eb8021ac27

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant