openpdf-html css style does not load

[fosJoddie]

Describe the bug

It looks like the changes in https://github.com/LibrePDF/OpenPDF/pull/1348/files caused (some?) css files to stop loading with a silent unexpected EOF

To Reproduce

My css starts with

@page {
    size: a4 portrait;
    margin: 0;
}

@media print {
    footer {
        page-break-after: always;
    }
}

which throws exception after handling of @ media element.

Expected behavior

CSS stylesheet is loaded and generated PDF is pretty

Screenshots

Current PDF (top left)

Correct PDF

System

• OS: MacOs and Windows
• Used font: NA
• OpenPDF version: 2.2.1

Additional context

the break inside this switch only breaks out of the switch and not the loop, around line 422 in org.openpdf.css.parser.CSSParser.java

switch (t.getType()) {
                                case RBRACE:
                                    next();
                                    break;
                                default:
                                    ruleset(mediaRule);
                            }

Suggested fix, tested ok locally

if (t.getType() == Type.RBRACE) {
   next();
   break;
} 
ruleset(mediaRule);

[fosJoddie]

Let me know if the steps to reproduce is not clear enough, I ran out of time to write a small reproducible code without dumping all our business logic

[andreasrosdalw]

This has been fixed on current master branch. Please test and let me know the results. This bug was caused when I had to fix a huge amount of code changes in order to get Sonarcloud to build without any errors.

A new release of OpenPDF will be available soon, we are migrating to a new maven central, so it could be more difficult than normal to make the release.

More testing of OpenPDF-html would be welcome.

Fix here: 6b75fd2

[andreasrosdalw]

Openpdf 2.2.3 has been released, with a fix for this.

[fosJoddie]

@andreasrosdal
Thanks for the fast fix. I can confirm this works fine, and all our (x)html -> PDF integrations are now working flawless on openpdf-html.