fix: store the date that the file was signed #5230
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sign engine is used to sign the file and between the interval that the file was signed and the moment to save this at the database, is possible to be different. To prevent issues about different dates (seconds or milisseconds), I made a parse at signed file and after then, I fetch the last signature date to store this at signed field at the database. Signed-off-by: Vitor Mattos <[email protected]>
|
/backport to stable31 |
|
/backport to stable30 |
Signed-off-by: Vitor Mattos <[email protected]>
AntDavidLima
approved these changes
Jul 22, 2025
samuelsonbrito
approved these changes
Jul 22, 2025
Signed-off-by: Vitor Mattos <[email protected]>
We will need to use the method generateCertificate at Pkcs7Handler that is a child of SignEngineHandler. Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The sign engine is used to sign the file and between the interval that the file was signed and the moment to save this at the database, is possible to be different. To prevent issues about different dates (seconds or milisseconds), I made a parse at signed file and after then, I fetch the last signature date to store this at signed field at the database.
The unit test that was changed don't validate this scenario because this test have a lot of mocks. I didn't implemented more tests because to sign a document will be necessary use the PKCS12 engine and to this will be necessary download a lot of dependencies making the unit test more slow.
Maybe would be good think more about how to implement more tests to cover this change.
Pull request checklist