Add pip dependency to resolve hanging custom_work_dependency test
#15429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otaj
requested review from
tchaton,
awaelchli,
manskx and
hhsecond
as code owners
github-actions
bot
added
the
app (removed)
awaelchli
approved these changes
Oct 31, 2022
|
@otaj seems to hang on flow is not ready... |
|
Is this PR a patch for #15417? If so, it's just been fixed by #15431. See its CI run in master: https://dev.azure.com/Lightning-AI/lightning/_build/results?buildId=111417&view=results |
|
I think that #15431 was a hotfix to unblock the master but not addressing the underlying issue... |
|
@akihironitta mind checking this PR if it is still relevant? Would greatly appreciate if you could take it over or just close it. |
|
Closing this PR as the reason for the hang was because of the very outdated docker image used in CI as I confimed with Mansy last week in #15417. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully resolves hang happening in
custom_work_dependencytest, that is blocking app framework.The related issue pypa/pip#11387
cc @carmocca @akihironitta @Borda @manskx