fix: disable non-blocking on MPS#3101
Merged
Merged
Conversation
ahmedhshahin
requested review from
Borda,
SkafteNicki and
justusschock
as code owners
for more information, see https://pre-commit.ci
Borda
approved these changes
May 22, 2025
4 tasks
Borda
reviewed
May 22, 2025
| rank_zero_warn("Detected zero division in _safe_divide. Setting 0/0 to 0.0") | ||
| zero_division = 0.0 if zero_division == "warn" else zero_division | ||
| zero_division_tensor = torch.tensor(zero_division, dtype=num.dtype).to(num.device, non_blocking=True) | ||
| # MPS does not support non blocking |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3101 +/- ##
=======================================
- Coverage 70% 70% -0%
=======================================
Files 357 343 -14
Lines 19831 19643 -188
=======================================
- Hits 13880 13693 -187
+ Misses 5951 5950 -1 🚀 New features to boost your workflow:
|
Borda
added a commit
that referenced
this pull request
May 27, 2025
* fix: disable non-blocking on MPS * chlog --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka B <j.borovec+github@gmail.com> (cherry picked from commit 23167cb)
Borda
added a commit
that referenced
this pull request
May 28, 2025
* fix: disable non-blocking on MPS * chlog --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka B <j.borovec+github@gmail.com> (cherry picked from commit 23167cb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the behavior of unexpected values when using
non_blocking=Trueon MPS cards.closes #3094
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--3101.org.readthedocs.build/en/3101/