fix: MSSSIM and SSIM dist_reduce_fx when reduction=None for distributed training #3166
Conversation
Borda
left a comment
There was a problem hiding this comment.
can we have a test for it?
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3166 +/- ##
=======================================
- Coverage 70% 70% -0%
=======================================
Files 364 349 -15
Lines 20063 19868 -195
=======================================
- Hits 14090 13896 -194
+ Misses 5973 5972 -1 🚀 New features to boost your workflow:
|
MultiScaleStructuralSimilarityIndexMeasure dist_reduce_fx when reduction=None for distributed trainingMultiScaleStructuralSimilarityIndexMeasure dist_reduce_fx when reduction=None for distributed training[wip]
So, you say that the patch resolves the problem, but it is difficult to create a test for it? |
MultiScaleStructuralSimilarityIndexMeasure dist_reduce_fx when reduction=None for distributed training[wip]MultiScaleStructuralSimilarityIndexMeasure dist_reduce_fx when reduction=None for distributed training [wip]
|
finally able to reproduce the issue |
MultiScaleStructuralSimilarityIndexMeasure dist_reduce_fx when reduction=None for distributed training [wip]MultiScaleStructuralSimilarityIndexMeasure dist_reduce_fx when reduction=None for distributed training [wip]
MultiScaleStructuralSimilarityIndexMeasure dist_reduce_fx when reduction=None for distributed training [wip]dist_reduce_fx when reduction=None for distributed training
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
What does this PR do?
Fixes issue mentioned in #3159 (comment) also adds test for #3162.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--3166.org.readthedocs.build/en/3166/