node 0.8 lacks `Buffer.isEncoding`

[ljharb]

Would you be willing to accept a PR that fixes that, and adds an engines.node declaration?

for reference, the actual entire implementation of it in node 0.10 is:

function (encoding) {
  switch (encoding && encoding.toLowerCase()) {
    case 'hex':
    case 'utf8':
    case 'utf-8':
    case 'ascii':
    case 'binary':
    case 'base64':
    case 'ucs2':
    case 'ucs-2':
    case 'utf16le':
    case 'utf-16le':
    case 'raw':
      return true;
    default:
      return false;
  }
}

[LinusU]

This library returns an instance of the global Buffer instance unmodified. It also purposefully doesn't modify any global variables, but rather just exports a new function.

I'm not sure that patching in Buffer.isEncoding would be in line with the spirit of that?

Are you envisioning that loading this library would patch on isEncoding onto the global Buffer object?

[ljharb]

Neither :-) just that when the method didn’t exist, it’d use an inline fallback, so it doesn’t crash. I can put up a PR tomorrow?

[LinusU]

Ahh, now I understand. Yeah, sounds good 👍

[ljharb]

#15

[LinusU]

Closing after discussion in #15, could revisit this if someone has a compelling argument for supporting that old versions of Node...