Add module, jsnext:main to package.json #249
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey. I'm using your excellent logger in a package which I build using rollup. I grab the ES6 sources from various node_modules and then bundle everything together in a single JS file which I serve up.
In order for rollup to do its thing properly, it needs an idea of where the ES6 sources live, which it gets from this value in your
package.json
file. So, if you'd like, here's that 2-line change to make it happen.Here's a bit of background on the
pkg.module
property.If you want to merge it back into the main project that would be nice, then I don't have to maintain my own fork. 😄 Thanks!