fix: genre translated in other languages to only english#9
Merged
LucasOe merged 1 commit intoLucasOe:mainfrom Feb 27, 2025
Merged
fix: genre translated in other languages to only english#9LucasOe merged 1 commit intoLucasOe:mainfrom
LucasOe merged 1 commit intoLucasOe:mainfrom
Conversation
Signed-off-by: sinjed <oooguuh@gmail.com>
Owner
|
Thank you, again, for your contribution! |
Closed
Contributor
Author
|
No problem and also dont make a release yet because i notice that we cant click on related genres anymore because i added a condition and i am working on it sorry |
Owner
|
I noticed that I couldn't click on the related genres, but I didn't think it was because of your changes. The only way I was able to solve it was with a timeout in 9aaf44a, did you pull the latest changes? But if you find a better solution, feel free to submit it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: The code retrieve the genres with the user local language, so it will not work for people that have their application in a different language than english
Solution: I just added the parameter
locale=EN_enwhen fetching the artist genresRelated issue:
#6