For the untracked test, avoid files on staging area

[beto-aveiga]

When doing a commit check, I've seen the following error:

[test:untracked] M  .github/workflows/PantheonDevDeploy.yml
[test:untracked] Untracked changes detected - please rectify or add the files to your .gitignore
task: Failed to run task "test:static": exit status 1
Failed to run task test:static: exit status 201            

The pre-commit runs:

#!/bin/sh

ddev task test:static

And task test:static runs:

    deps: [lint, phpstan, phpunit:static, phpcs]
    cmds:
      - task: untracked

Then the untracked script should not consider files in the stage area of a commit.

This is what I expect

Error: untracked or modified files not added to the stage area

No error: no unstaged changes or untracked files

[YesCT]

What is the change in .github/workflows/PantheonDevDeploy.yml that is untracked?
Maybe it should be committed?? Or maybe the thing making the change... should not be making the change??

[beto-aveiga]

@YesCT: it is just an example.

I was working on Lullabot and, when I tried to commit my change, I couldn't because the file I wanted to commit had been modified.

So, I think files in the stage area should not be counted for the untracked test. Only modified and untracked files should be counted if none of them are in the staging area.

[beto-aveiga]

The untracked test/check is coming from Drainpipe, so I think we should modify this test.

[YesCT]

Ah, so are you thinking we'd still get an error when deploy to dev but not on staging? Or are you thinking we should not get an untracked files error anywhere on the host dev/stage/prod. ... Only on tugboat and ddev locals?? Hm.

[beto-aveiga]

The untracked test is to avoid having modified or untracked files after building a site or running some commands.

So, if these untracked or modified files are already in the Git staging area, why should we worry about them? Our script is somehow controlling those changes. And that makes it also compatible for running the static tests on a pre-commit hook.

[deviantintegral]

I wonder if we should consider building on or migrating to https://github.com/pre-commit/pre-commit for this sort of thing.