Skip to content

Fix Redux DevTools freezing #LMR-797 #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

livthomas
Copy link
Member

Have you ever wondered why Redux DevTools are often freezing? Here is the answer:

Angular router classes create a complicated hierarchies with many cyclic references. Redux DevTools always try to serialize the content of the store and they go into the depth. The result was 2GB RAM taken by Redux DevTools and the eventual crash of the extension.

See this NgRx issue and this section of the documention.

* Do not keep the hierarchy of Angular router objects in the store.
@kubedo8
Copy link
Contributor

kubedo8 commented Mar 26, 2018

Awesome! I have prayed many times for it to work well..many thanks 👍

@livthomas livthomas merged commit b7ac209 into Lumeer:devel Mar 26, 2018
@livthomas livthomas deleted the redux-devtools-freezing branch March 26, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants