Skip to content

fix: warn about go 1.24 toolchain usage [IAC-3259] #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

mihai-snyk
Copy link

@mihai-snyk mihai-snyk commented Mar 21, 2025

For some reason (lightly explained in this thread golang/go#71757) the sig scheme based on P521 curve was removed in Go 1.24, so that’s why we can get handshake failures if we'll do the upgrade.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@mihai-snyk mihai-snyk force-pushed the fix/IAC-3259/warn-about-golang-1-24-usage branch from 5236029 to 304e798 Compare March 21, 2025 15:07
@Lekensteyn
Copy link

In case you were not aware, this will be fixed in Go 1.24.2 (golang/go#72823) which will probably be released in 2 weeks.

@mihai-snyk mihai-snyk merged commit 4612513 into snyk Mar 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants