Open
Conversation
n1k0
changed the title
n1k0
force-pushed
the
feat/check-component-config
branch
from
db8a0a5 to
38e81d3
Compare
n1k0
force-pushed
the
feat/check-component-config
branch
from
38e81d3 to
458398a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Problem
There's currently no validation of component config validity in the CI.
🍰 Solution
This patch adds component config check to the
db:checkcommand, which is run by the CI.🏝️ How to test
The command reuse existing runtime parsing code, which is already tested. Build should just be green