[AIS] Configuration de kafka #2622
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
maximeperraultdev
force-pushed
the
maxime/tech/setup_kafka_consumer
branch
from
f0de398 to
de795f9
Compare
louptheron
left a comment
louptheron
left a comment
There was a problem hiding this comment.
LGTM, quelques petits commentaires de naming
| hikari: | ||
| maxLifetime: 60000 | ||
| kafka: | ||
| bootstrap-servers: ${MONITORENV_KAFKA_SERVERS} |
There was a problem hiding this comment.
| bootstrap-servers: ${MONITORENV_KAFKA_SERVERS} | |
| bootstrap-servers: ${MONITORENV_KAFKA_AIS_SERVERS} |
Je propose de rajouter AIS pour que ça soit explicite
| kafka: | ||
| bootstrap-servers: ${MONITORENV_KAFKA_SERVERS} | ||
| consumer: | ||
| group-id: ${MONITORENV_KAFKA_GROUP_ID} |
There was a problem hiding this comment.
| group-id: ${MONITORENV_KAFKA_GROUP_ID} | |
| group-id: ${MONITORENV_KAFKA_AIS_GROUP_ID} |
Same
|
|
||
| @EnableKafka | ||
| @Configuration | ||
| class KafkaConsumerConfig( |
There was a problem hiding this comment.
Perso j'aurais mis ça dans le dossier infrastructure car c'est relatif à la récepeption de l'AIS ? C'est plus du taste.
à minima, KafkaAISConsumerConfig` ?
There was a problem hiding this comment.
question: on a groupé toutes les config dans le meme dossier. Ca me choque pas de trier les configs infra/domaine mais il faudrait le faire pour tous
maximeperraultdev
force-pushed
the
maxime/tech/setup_kafka_consumer
branch
5 times, most recently
from
a92a667 to
b82b13d
Compare
maximeperraultdev
force-pushed
the
maxime/tech/setup_kafka_consumer
branch
from
b82b13d to
f94c853
Compare
|
Related Pull Requests & Issues