[Brief] N'afficher les amp sur la page de garde du brief que s'il y en a #2696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claire2212
added
feat. enhancement
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
claire2212
force-pushed
the
claire/brief-delete-amp-in-summary
branch
from
ceb5752 to
3711445
Compare
|
maximeperraultdev
approved these changes
Jan 19, 2026
Collaborator
maximeperraultdev
left a comment
maximeperraultdev
left a comment
There was a problem hiding this comment.
LGTM (une petite question cependant)
| placeholders["\${totalRegulatoryAreasText}"] = buildCountText("zones réglementaires", regulatoryCount, true) | ||
| placeholders["\${totalRegulatoryAreas}"] = regulatoryCount.toString() | ||
|
|
||
| if (ampCount > 0) { |
Collaborator
There was a problem hiding this comment.
question: est-ce qu'on devrait étendre cette logique aux autres objets du dashboard ?
Collaborator
Author
There was a problem hiding this comment.
@maximeperraultdev je pense qu'il y a quasiment toujours des zones reg et ZDV sélectionnés, c'est pour ça que Pierre n'en a pas parlé dans le ticket. On pourra le faire plus tard si le besoin est là
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Pull Requests & Issues