Skip to content
This repository was archived by the owner on May 3, 2023. It is now read-only.

mac builds back to 10.6 #38

Merged
merged 1 commit into from
Jan 6, 2019
Merged

Conversation

robbuckley
Copy link
Contributor

fixes #37

@jreback
Copy link
Contributor

jreback commented Jan 5, 2019

ok this is fine. ping on green (though I have been fixing this branch, so hopefully you are rebased to the latest).

@robbuckley
Copy link
Contributor Author

@jreback build is green. Looks like i already rebased on all your changes from yesterday

@jreback jreback merged commit fa530f8 into MacPython:daily Jan 6, 2019
@jreback
Copy link
Contributor

jreback commented Jan 6, 2019

thanks @robbuckley

jreback pushed a commit that referenced this pull request Jan 6, 2019
@jreback
Copy link
Contributor

jreback commented Jan 6, 2019

ok wheels have built, if you would give a quick verification of these would be great: https://travis-ci.org/MacPython/pandas-wheels/builds/476008614 (I guess meaning they correctly install)

@robbuckley
Copy link
Contributor Author

robbuckley commented Jan 7, 2019

OK i've downloaded the 3 mac wheels and installed each locally in a fresh conda environment, and for good measure run pandas.test() on each. The 2.7 wheel had 1 failure, i think its a known issue (?)

TestDatetimeIndexTimezones.test_dti_tz_localize_roundtrip[tz_aware_fixture6-idx3]
../anaconda3/envs/py27/lib/python2.7/site-packages/pandas/tests/indexes/datetimes/test_timezones.py:448: AssertionError

the 3.5 and 3.6 wheel tests installed OK, tests are still running, i will update in the morning

@robbuckley
Copy link
Contributor Author

this went quicker than i thought - tests on 3.5 and 3.6 wheels completed, with exactly the same single failure as 2.7

@robbuckley
Copy link
Contributor Author

robbuckley commented Jan 8, 2019

I built the same commit on master locally, and got exactly the same failure. I didnt set any env var before my local build, so it was built for macosx 10.9 (iie without the change in this PR). So therefore i dont think this failure is related to my change.

But the same commit passes green in CI (7c842b0312064bbc6bf1201ba6dbb774da90ba0d) so I cant see why it fails on my machine. See below the full text of the fail

@jreback should i raise a bug?

___________________________________________________________ TestDatetimeIndexTimezones.test_dti_tz_localize_roundtrip[tz_aware_fixture6-idx3] ___________________________________________________________

self = <pandas.tests.indexes.datetimes.test_timezones.TestDatetimeIndexTimezones object at 0x1c5405e908>, tz_aware_fixture = tzlocal()
idx = DatetimeIndex(['2014-08-01 00:00:00', '2014-08-01 00:01:00',
               '2014-08-01 00:02:00', '2014-08-01 00:03:0...          '2014-10-30 23:59:00', '2014-10-31 00:00:00'],
              dtype='datetime64[ns]', length=131041, freq='T')

    @pytest.mark.parametrize('idx', [
        date_range(start='2014-01-01', end='2014-12-31', freq='M'),
        date_range(start='2014-01-01', end='2014-12-31', freq='D'),
        date_range(start='2014-01-01', end='2014-03-01', freq='H'),
        date_range(start='2014-08-01', end='2014-10-31', freq='T')
    ])
    def test_dti_tz_localize_roundtrip(self, tz_aware_fixture, idx):
        tz = tz_aware_fixture
        localized = idx.tz_localize(tz)
        expected = date_range(start=idx[0], end=idx[-1], freq=idx.freq,
                              tz=tz)
>       tm.assert_index_equal(localized, expected)
E       AssertionError: Index are different
E       
E       Index length are different
E       [left]:  131041, DatetimeIndex(['2014-08-01 00:00:00+01:00', '2014-08-01 00:01:00+01:00',
E                      '2014-08-01 00:02:00+01:00', '2014-08-01 00:03:00+01:00',
E                      '2014-08-01 00:04:00+01:00', '2014-08-01 00:05:00+01:00',
E                      '2014-08-01 00:06:00+01:00', '2014-08-01 00:07:00+01:00',
E                      '2014-08-01 00:08:00+01:00', '2014-08-01 00:09:00+01:00',
E                      ...
E                      '2014-10-30 23:51:00+00:00', '2014-10-30 23:52:00+00:00',
E                      '2014-10-30 23:53:00+00:00', '2014-10-30 23:54:00+00:00',
E                      '2014-10-30 23:55:00+00:00', '2014-10-30 23:56:00+00:00',
E                      '2014-10-30 23:57:00+00:00', '2014-10-30 23:58:00+00:00',
E                      '2014-10-30 23:59:00+00:00', '2014-10-31 00:00:00+00:00'],
E                     dtype='datetime64[ns, tzlocal()]', length=131041, freq='T')
E       [right]: 131101, DatetimeIndex(['2014-08-01 00:00:00+01:00', '2014-08-01 00:01:00+01:00',
E                      '2014-08-01 00:02:00+01:00', '2014-08-01 00:03:00+01:00',
E                      '2014-08-01 00:04:00+01:00', '2014-08-01 00:05:00+01:00',
E                      '2014-08-01 00:06:00+01:00', '2014-08-01 00:07:00+01:00',
E                      '2014-08-01 00:08:00+01:00', '2014-08-01 00:09:00+01:00',
E                      ...
E                      '2014-10-30 23:51:00+00:00', '2014-10-30 23:52:00+00:00',
E                      '2014-10-30 23:53:00+00:00', '2014-10-30 23:54:00+00:00',
E                      '2014-10-30 23:55:00+00:00', '2014-10-30 23:56:00+00:00',
E                      '2014-10-30 23:57:00+00:00', '2014-10-30 23:58:00+00:00',
E                      '2014-10-30 23:59:00+00:00', '2014-10-31 00:00:00+00:00'],
E                     dtype='datetime64[ns, tzlocal()]', length=131101, freq='T')

pandas/tests/indexes/datetimes/test_timezones.py:448: AssertionError

@jreback
Copy link
Contributor

jreback commented Jan 8, 2019

check that you have the require version of dateutil

@robbuckley
Copy link
Contributor Author

i have 2.7.5 installed, requirements-dev.txt specifies python-dateutil>=2.5.0

@jreback
Copy link
Contributor

jreback commented Jan 8, 2019

i guess raise an issue

@robbuckley robbuckley deleted the mac10_6_daily branch June 23, 2019 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants