Skip to content
This repository was archived by the owner on May 3, 2023. It is now read-only.

add mac wheels built for 10.9 / 64b only #46

Merged
merged 4 commits into from
Mar 27, 2019
Merged

add mac wheels built for 10.9 / 64b only #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e45645
update multibuild
robbuckley Mar 24, 2019
e0acf2c
add macos 10.9 targets
robbuckley Mar 24, 2019
fa1d4e1
move MACOSX_DEPLOYMENT_TARGET override out of travis.yml
robbuckley Mar 24, 2019
7e9af17
no 3.5 build for 10.9. add 3.7 build
robbuckley Mar 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,22 @@ matrix:
language: generic
env:
- MB_PYTHON_VERSION=3.5
- MACOSX_DEPLOYMENT_TARGET=10.6 # since pandas PR24274, mac builds default to 10.9
- os: osx
language: generic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robbuckley is there a reason this 3.6 job is still here? also the 3.5 wheel doesn't have MB_PYTHON_OSX_VER=10.9 is that ok?

Copy link
Contributor Author

@robbuckley robbuckley Mar 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback the 3.6 / 10.6 job can go. The 3.5 job is built for 10.6 / dual arch because python.org only provide 10.9 / 64b builds of CPython for 3.6.5 and up, and thats what multibuild uses to build the wheels. So if you need to provide a 3.5 wheel, it will have to be 10.6 / dual arch, with the way multibuild is currently implemented

env:
- MB_PYTHON_VERSION=3.6
- MACOSX_DEPLOYMENT_TARGET=10.6 # since pandas PR24274, mac builds default to 10.9


- os: osx
language: generic
env:
- MB_PYTHON_VERSION=3.6
- MB_PYTHON_OSX_VER=10.9
- os: osx
language: generic
env:
- MB_PYTHON_VERSION=3.7
- MB_PYTHON_OSX_VER=10.9
- NP_BUILD_DEP="numpy==1.14.5"
- NP_TEST_DEP="numpy==1.14.5"

before_install:
# See:
Expand Down
7 changes: 6 additions & 1 deletion config.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@
function pre_build {
# Any stuff that you need to do before you start building the wheels
# Runs in the root directory of this repository.
:
if [ -n "$IS_OSX" ]; then
# Override pandas minimum MACOSX_DEPLOYEMENT_TARGET=10.9 so we can
# build for older Pythons
# See https://github.com/pandas-dev/pandas/pull/24274
export MACOSX_DEPLOYMENT_TARGET=${MACOSX_DEPLOYMENT_TARGET:-$(get_macpython_osx_ver)}
fi
}

function build_wheel {
Expand Down
2 changes: 1 addition & 1 deletion multibuild
Open in desktop
Submodule multibuild updated 18 files
+6 −0 .appveyor.yml
+44 −9 .travis.yml
+1 −1 LICENSE
+27 −13 README.rst
+11 −17 common_utils.sh
+10 −2 configure_build.sh
+1 −1 docker_test_wrap.sh
+4 −6 library_builders.sh
+2 −2 manylinux_utils.sh
+153 −51 osx_utils.sh
+2 −10 tests/test_fill_pypy_ver.sh
+0 −4 tests/test_fill_pyver.sh
+3 −2 tests/test_library_builders.sh
+1 −7 tests/test_manylinux_utils.sh
+2 −1 tests/test_multibuild.sh
+25 −10 tests/test_osx_utils.sh
+13 −4 tests/test_python_install.sh
+10 −1 tests/test_supported_wheels.sh