Add test for preexec_fn fd double close issue #479
Conversation
|
@graingert may I ask for a review pls? |
Co-authored-by: Thomas Grainger <[email protected]>
| asyncio.run(test()) | ||
| fut.result() | ||
| """) | ||
| subprocess.check_call([sys.executable, '-c', script]) |
There was a problem hiding this comment.
| subprocess.check_call([sys.executable, '-c', script]) | |
| subprocess.run([sys.executable, '-c', script], check=True) |
Just doing a eyeball pass at the moment - will do a proper review later. My gut feeling is that I think it's a bit complicated using a thread pool executor and a queue and a pipe and an event so I'll see if I can have a ponder on making this simpler - eg just using threading.Barrier |
| import asyncio | ||
| import uvloop | ||
|
|
||
| uvloop.install() |
There was a problem hiding this comment.
When the 3.11 test suite lands it might be worth conditionally using the modern asyncio.Runner(loop_factory=uvloop.new_event_loop)
ok I think I've managed to simplify this a lot: https://github.com/MagicStack/uvloop/pull/481/files#r924838769 |
|
Close in favor of #481 |
Refs #466